Bump TypeScript 5 and Inversify 6 #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaisalmen
force-pushed
the
kaisalmen/ts5-inversify6
branch
2 times, most recently
from
6fe4f94
to
add255e
Compare
Declare inversify as peerDependency
kaisalmen
force-pushed
the
kaisalmen/ts5-inversify6
branch
from
add255e
to
445ceb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When upgrading to TypeSript 5 and using
@injectin a constructor the following error is raised:Upgrading to inversify 6 resolves the issue.
See this comment: microsoft/TypeScript#52435 (comment) and the following.
Related: eclipse-theia/theia#12425
Inversify is now a
peerDependencyaddressing: #296